Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set reserve-space = 0MB for TiKV 4.0+ in e2e tests #2514

Merged
merged 3 commits into from
May 21, 2020
Merged

Set reserve-space = 0MB for TiKV 4.0+ in e2e tests #2514

merged 3 commits into from
May 21, 2020

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented May 21, 2020

What problem does this PR solve?

fixes #2509

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

@cofyc
Copy link
Contributor Author

cofyc commented May 21, 2020

/run-e2e-tests

Yisaer
Yisaer reviewed May 21, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

pkg/apis/pingcap/v1alpha1/tikv_config.go Show resolved Hide resolved
@Yisaer Yisaer mentioned this pull request May 21, 2020
Merged
DanielZhangQD
DanielZhangQD previously approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Yisaer
Yisaer previously approved these changes May 21, 2020
View reviewed changes
@Yisaer
Copy link
Contributor

Yisaer commented May 21, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 21, 2020

/run-all-tests

@cofyc cofyc dismissed stale reviews from Yisaer and DanielZhangQD via 3faac28 May 21, 2020 05:10
@cofyc cofyc requested a review from DanielZhangQD May 21, 2020 06:23
DanielZhangQD
DanielZhangQD approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc cofyc merged commit 6d16942 into pingcap:master May 21, 2020
sre-bot pushed a commit to sre-bot/tidb-operator that referenced this pull request May 21, 2020
@cofyc @sre-bot
Set reserve-space = 0MB for TiKV 4.0+ in e2e tests (pingcap#2514)
6cbc081 
* Set `reserve-space = 0MB` for TiKV 4.0+ in e2e tests

* auto-generated files

* retry to tolerate network failures
@sre-bot sre-bot mentioned this pull request May 21, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented May 21, 2020

cherry pick to release-1.1 in PR #2520

sre-bot added a commit that referenced this pull request May 21, 2020
@sre-bot
Set reserve-space = 0MB for TiKV 4.0+ in e2e tests (#2514) (#2520)
b22f91a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

Assignees
No one assigned
Labels
CanMerge needs-cherry-pick-1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set reserve-space = 0MB for TiKV 4.0+ in e2e tests
4 participants
@cofyc @Yisaer @sre-bot @DanielZhangQD