Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable customizing mydumper options in CRD backup (#2407) #2453

Merged
merged 2 commits into from
May 13, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 13, 2020

cherry-pick #2407 to release-1.1


What problem does this PR solve?

This PR resolve #2391

What is changed and how does it work?

Support specifying mydumper options in the backup which can be used during backup with mydumper.
The mydumper options can refer to this doc

backup CR example:

---
apiVersion: pingcap.com/v1alpha1
kind: Backup
metadata:
  name: demo1-backup-s3
  namespace: test1
spec:
  from:
    host: demo1-tidb
    port: 4000
    user: root
    secretName: backup-demo1-tidb-secret
  s3:
    provider: aws
    bucket: test1-demo1
    region: us-west-2
    secretName: aws-secret
  mydumper:
    options:
    - --threads=16
    - --rows=10000
    - --skip-tz-utc
  storageClassName: local-storage
  storageSize: 1Gi

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Support customizing `mydumper` options in Backup CR

* enable customizing mydumper options in CRD backup

* add unit tests
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented May 13, 2020

Your auto merge job has been accepted, waiting for:

  • 2451
  • 2449

@sre-bot
Copy link
Contributor Author

sre-bot commented May 13, 2020

/run-all-tests

@sre-bot sre-bot merged commit ad25153 into pingcap:release-1.1 May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants