Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS: configuration is change via tikv (#2334) #2351

Merged
merged 3 commits into from
Apr 30, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 29, 2020

cherry-pick #2334 to release-1.1


What problem does this PR solve?

configuration is change via tikv

Check List

Tests

  • Manual test

Code changes

  • Has Go code change
Modify the json tag and toml tag of the field `spec.tikv.config.encrpytion.method` , from `method` to `data-encryption-method`

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 29, 2020

/run-all-tests

@cofyc cofyc mentioned this pull request Apr 29, 2020
4 tasks
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 29, 2020

@sre-bot merge failed.

@DanielZhangQD
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 30, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 30, 2020

/run-all-tests

@sre-bot sre-bot merged commit e5f9077 into pingcap:release-1.1 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants