Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add DOCKER_REPO to specify full image repository (#2207) #2216

Merged
merged 3 commits into from
Apr 17, 2020
Merged

add DOCKER_REPO to specify full image repository (#2207) #2216

merged 3 commits into from
Apr 17, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 16, 2020

cherry-pick #2207 to release-1.1

What problem does this PR solve?

See examples:

DOCKER_REPO=hub.pingcap.net/fuyecheng make docker
docker push hub.pingcap.net/fuyecheng/tidb-backup-manager:latest

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

@sre-bot sre-bot mentioned this pull request Apr 16, 2020
Merged
DanielZhangQD
DanielZhangQD approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc
Copy link
Contributor

cofyc commented Apr 17, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 17, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 17, 2020

@sre-bot merge failed.

@cofyc
Copy link
Contributor

cofyc commented Apr 17, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 17, 2020

Your auto merge job has been accepted, waiting for 2220

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 17, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 17, 2020

@sre-bot merge failed.

@cofyc
Copy link
Contributor

cofyc commented Apr 17, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 17, 2020

/run-all-tests

@sre-bot sre-bot merged commit dbd721a into pingcap:release-1.1 Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@aylei aylei Awaiting requested review from aylei

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees
No one assigned
Labels
CanMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sre-bot @cofyc @DanielZhangQD