Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pd-failover: scale out directly when failover occurs #217

Merged
merged 2 commits into from
Dec 6, 2018

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Dec 6, 2018

@weekface
Copy link
Contributor Author

weekface commented Dec 6, 2018

/run-e2e-tests

2 similar comments
@onlymellb
Copy link
Contributor

/run-e2e-tests

@weekface
Copy link
Contributor Author

weekface commented Dec 6, 2018

/run-e2e-tests

normalPDMember(tc)
tc.Status.PD.FailureMembers = map[string]v1alpha1.PDFailureMember{
"pd-0": {PodName: "pd-0"},
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tc.Status.PD.Members["pd-0"].Health=false

Copy link
Contributor

@xiaojingchen xiaojingchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaojingchen
Copy link
Contributor

run-e2e-tests

@xiaojingchen
Copy link
Contributor

/run-e2e-tests

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaojingchen xiaojingchen merged commit b9ba8ba into pingcap:master Dec 6, 2018
queenliuxx pushed a commit to queenliuxx/tidb-operator that referenced this pull request Dec 19, 2018
* fix pd-failover: scale out directly when failover occurs

* address comment
@weekface weekface deleted the fix-pd-failover branch June 21, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants