Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix terraform destroy failure on aws (#2148) #2154

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 10, 2020

cherry-pick #2148 to release-1.1


What problem does this PR solve?

Fix #2144

What is changed and how does it work?

Do not make kubeconfig file as resources so that it will not be removed at the beginning phase of terraform destroy.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • Run terraform apply and then terraform destroy, the cluster is destroyed successfully.

Code changes

  • Has Terraform scripts change

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

Fix the failure that Helm cannot load the kubeconfig file when deleting the tidb-operator release during `terraform destroy`

@DanielZhangQD DanielZhangQD merged commit 7b852ee into pingcap:release-1.1 Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants