Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine tidb_cluster_control codes #215

Merged
merged 6 commits into from
Dec 18, 2018

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Dec 6, 2018

  • move PDIsAvailable and TiKVIsAvailable method and unit tests to TidbCluster
  • refine tidb_cluster_control.go codes, add more documents to enhance code readability
  • adjust other packages unit code

@tennix @onlymellb @xiaojingchen PTAL

Copy link
Contributor

@xiaojingchen xiaojingchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xiaojingchen
xiaojingchen previously approved these changes Dec 13, 2018
@weekface
Copy link
Contributor Author

@tennix PTAL

tennix
tennix previously approved these changes Dec 18, 2018
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor Author

/run-e2e-tests

@weekface weekface dismissed stale reviews from tennix and xiaojingchen via 4d191cc December 18, 2018 09:11
@weekface
Copy link
Contributor Author

/run-e2e-tests

@weekface
Copy link
Contributor Author

/run-e2e-tests

@weekface weekface merged commit 19a76e1 into pingcap:master Dec 18, 2018
@weekface weekface deleted the refine-tidb-cluster-control branch December 18, 2018 09:48
queenliuxx pushed a commit to queenliuxx/tidb-operator that referenced this pull request Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants