Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PD Dashboard Config when TLS Client enabled (#2085) #2130

Closed
wants to merge 7 commits into from

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 7, 2020

cherry-pick #2085 to release-1.1


What problem does this PR solve?

fixes #2078

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

Set PD Dashboard Config when TLS Client enabled

weekface and others added 4 commits April 7, 2020 18:38
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor

weekface commented Apr 7, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 7, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 7, 2020

@sre-bot merge failed.

@Yisaer
Copy link
Contributor

Yisaer commented Apr 10, 2020

It seems you need to cherry-pick the commit the update the documents by scripts manually. @weekface

I0409 08:16:29.052354   27781 main.go:161] written to /home/runner/work/tidb-operator/tidb-operator/go/src/github.com/pingcap/tidb-operator/docs/api-references/docs.md
diffing manifests/crd.yaml with /tmp/tmp.cPgizPntwr
diffing /home/runner/work/tidb-operator/tidb-operator/go/src/github.com/pingcap/tidb-operator/docs/api-references/docs.md with /tmp/tmp.A3thjzcZON
4439a4440,4452
> <tr>
> <td>
> <code>dashboard</code></br>
> <em>
> <a href="#pingcap.com/v1alpha1.DashboardConfig">
> DashboardConfig
> </a>
> </em>
> </td>
> <td>
> <em>(Optional)</em>
> </td>
> </tr>
4885,4897d4897
< </td>
< </tr>

@weekface
Copy link
Contributor

new pr opened: #2152, closing

@weekface weekface closed this Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants