Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: fix kms bug (#1955) #1973

Merged
merged 2 commits into from
Mar 20, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 18, 2020

cherry-pick #1955 to release-1.1


What problem does this PR solve?

fix problem when kms is used and without set default aws region

What is changed and how does it work?

set region in operator when kms is used

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has Go code change

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc cofyc merged commit 4023a35 into pingcap:release-1.1 Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants