fix pd_control: not rely on error text #197
Conversation
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
| if strings.Contains(err2.Error(), schedulerExisted) { | ||
| return nil | ||
|
|
||
| evictLeaderSchedulers, err := pc.GetEvictLeaderSchedulers() |
There was a problem hiding this comment.
this should be exec before create evict leader, if the scheduler leader exists, then not need to post sheduler leader
There was a problem hiding this comment.
This replaces of strings.Contains, placed behind evicting leader is ok.
| err2 := readErrorBody(res.Body) | ||
| if strings.Contains(err2.Error(), schedulerNotFound) { | ||
| return nil | ||
| evictLeaderSchedulers, err := pc.GetEvictLeaderSchedulers() |
There was a problem hiding this comment.
This replaces of strings.Contains, placed behind evicting leader is ok.
| if strings.Contains(bodyStr, "store has been removed") { | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
PD now actually returns a structured json response with an error code and an error code as a header.
There was a problem hiding this comment.
Yes, but the older version don't have the error code and header.
Return the error is ok for this situation. The DeleteStore function is reentrant.
|
/run-e2e-tests |
|
/run-e2e-tests |
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Signed-off-by: liubo02 <liubo02@pingcap.com>
GetEvictLeaderSchedulersinstead@tennix @xiaojingchen PTAL