Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve note of failurePolicy and revise IDC configuration #1904

Merged
merged 3 commits into from
Mar 11, 2020
Merged

Improve note of failurePolicy and revise IDC configuration #1904

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7195246
improve note and revise idc config
Mar 11, 2020
d61b18a
Merge branch 'master' into improv_failure_policy_note
Yisaer Mar 11, 2020
9360eaa
Merge branch 'master' into improv_failure_policy_note
sre-bot Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions charts/tidb-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,11 @@ admissionWebhook:
## failurePolicy are applied to ValidatingWebhookConfiguration which affect tidb-admission-webhook
## refer to https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#failure-policy
failurePolicy:
## the validation webhook would check the request of the given resources, and the failurePolicy is recommended as Ignore
## the validation webhook would check the request of the given resources.
## If the kubernetes api-server version >= 1.15.0, we recommend the failurePolicy as Fail, otherwise, as Ignore.
validation: Ignore
## the mutation webhook would mutate the request of the given resources, and the failurePolicy is recommended as Ignore
## the mutation webhook would mutate the request of the given resources.
## If the kubernetes api-server version >= 1.15.0, we recommend the failurePolicy as Fail, otherwise, as Ignore.
mutation: Ignore
## tidb-admission-webhook deployed as kubernetes apiservice server
## refer to https://github.com/openshift/generic-admission-server
Expand Down
4 changes: 4 additions & 0 deletions ci/deploy_tidb_operator_staging.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,16 @@ scheduler:
replicas: 2
admissionWebhook:
create: true
replicas: 2
validation:
statefulSets: true
pods: true
pingcapResources: false
mutation:
pingcapResources: true
failurePolicy:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change them to Fail in IDC where the k8s version is v1.12, which does not match the descriptions in values.yaml updated above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDC is under our control, it's fine to set fail for failurePolicy in this case. For community customer, we still recommend set failurePolicy as Ignore as I mentioned in the note.

validation: Fail
mutation: Fail
features:
- AutoScaling=true
'''
Expand Down