keep scheduler name consistent as defined in values.yml #188
Conversation
|
/run-e2e-tests |
| @@ -26,7 +26,7 @@ spec: | |||
| serviceAccount: {{ .Values.scheduler.serviceAccount }} | |||
| {{- end }} | |||
| containers: | |||
| - name: tidb-scheduler | |||
| - name: {{ .Values.scheduler.schedulerName }} | |||
There was a problem hiding this comment.
Container name is used internally, using tidb-scheduler is handy for kubectl exec and kubectl logs. So it's unnecessary to change this.
There was a problem hiding this comment.
I think it's better to keep the name consistent, and it's not necessary to fix the container name to executing kubectl exec and kubectl logs
There was a problem hiding this comment.
If using tidb-scheduler as container name, the two container names are always tidb-scheduler and kube-scheduler. When debugging we can always use the same name without thinking what it is. Besides container name should reflect the actual image it uses other than using the installer specified name.
There was a problem hiding this comment.
If you want to use tidb-scheduler as container name, you can keep the schedulerName as default. But if you want to change the default value then keeping the container name consistent with it makes sense.
* Add markdownlint in CI Signed-off-by: Aylei <rayingecho@gmail.com> * Update .markdownlint.yaml Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Lilian Lee <lilin@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
The scheduler can't use scheduler policy configmap correctly when you change the schedulerName in values.yaml. This PR fix it.