Fix wrong method to get tikv configmap in mutation webhook (#1871) #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
sre-bot
added
area/webhook
Yisaer
approved these changes
Mar 6, 2020
|
/run-e2e-in-kind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1871 to release-1.1
What problem does this PR solve?
Currently the tikv Configmap wouldn't be fetched when we only using TidbCluster CR with
configUpdateStrategy: RollingUpdate. This request get the configmap from the volume template from the coming tikv pod.I haven tested all four situations( helm/cr, RollingUpdate/Inplace), all situtations work well
Fix the problem which would let the
Related changes
Does this PR introduce a user-facing change?: