Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default value for tidb / tikv / pd log level #185

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

cwen0
Copy link
Member

@cwen0 cwen0 commented Nov 19, 2018

if log-level is empty in tikv config file, starting tikv will fail.
In this pr, if the log-level is empty, it will be set to info.
@tennix @weekface @xiaojingchen PTAL

@cwen0
Copy link
Member Author

cwen0 commented Nov 19, 2018

@tennix @weekface PTAL again, thanks!

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix
Copy link
Member

tennix commented Nov 19, 2018

/run-e2e-tests

1 similar comment
@weekface
Copy link
Contributor

/run-e2e-tests

@weekface
Copy link
Contributor

/run-e2e-tests

@cwen0 cwen0 merged commit d3c7c90 into pingcap:master Nov 21, 2018
@cwen0 cwen0 deleted the cwen/fix_config_log_level branch November 21, 2018 02:17
queenliuxx pushed a commit to queenliuxx/tidb-operator that referenced this pull request Dec 19, 2018
fgksgf pushed a commit to fgksgf/tidb-operator that referenced this pull request Dec 23, 2024
Signed-off-by: liubo02 <liubo02@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants