Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine initial first pd member code #179

Merged
merged 3 commits into from
Nov 14, 2018

Conversation

weekface
Copy link
Contributor

  • refine initial first pd member code
  • add more unit test specs (pd_member_manager.go coverage from 71.1% to 78.8%)

@tennix @xiaojingchen PTAL

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor Author

/run-e2e-tests

2 similar comments
@weekface
Copy link
Contributor Author

/run-e2e-tests

@weekface
Copy link
Contributor Author

/run-e2e-tests

Copy link
Contributor

@xiaojingchen xiaojingchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor Author

/run-e2e-tests

@weekface weekface merged commit 8508dbd into pingcap:master Nov 14, 2018
@weekface weekface deleted the refine-init-first-pd-member branch November 14, 2018 09:22
queenliuxx pushed a commit to queenliuxx/tidb-operator that referenced this pull request Dec 19, 2018
fgksgf pushed a commit to fgksgf/tidb-operator that referenced this pull request Dec 23, 2024
Signed-off-by: liubo02 <liubo02@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants