Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check to see if the volumeName is empty before the sync pv labels #177

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Nov 9, 2018

This pr fixes #174, removes these noisy error messages.

@tennix @onlymellb @xiaojingchen @gregwebs PTAL

Copy link
Contributor

@gregwebs gregwebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor Author

/run-e2e-tests

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xiaojingchen
Copy link
Contributor

/run-e2e-tests

Copy link
Contributor

@xiaojingchen xiaojingchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit 75338e5 into pingcap:master Nov 13, 2018
@weekface weekface deleted the fix-pv-meta-sync branch November 13, 2018 02:19
queenliuxx pushed a commit to queenliuxx/tidb-operator that referenced this pull request Dec 19, 2018
fgksgf pushed a commit to fgksgf/tidb-operator that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty persistent volume sync
4 participants