Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter out master by role without relying on name #172

Merged
merged 2 commits into from
Nov 8, 2018
Merged

filter out master by role without relying on name #172

merged 2 commits into from
Nov 8, 2018

Conversation

gregwebs
Copy link
Contributor

@gregwebs gregwebs commented Nov 8, 2018

addresses #155

tennix
tennix approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix tennix merged commit df07912 into pingcap:master Nov 8, 2018
@tennix tennix deleted the pv-create-master-filter branch November 8, 2018 13:40
queenliuxx pushed a commit to queenliuxx/tidb-operator that referenced this pull request Dec 19, 2018
@gregwebs @tennix
filter out master by role without relying on name (pingcap#172)
8461d26
fgksgf added a commit to fgksgf/tidb-operator that referenced this pull request Dec 23, 2024
@fgksgf
Fix the pod may be not recreate when config is changed (pingcap#172)
911d384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tennix tennix tennix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregwebs @tennix