Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more unit tests and give priority to syncing reclaim policy #169

Merged
merged 8 commits into from
Nov 8, 2018
Merged

add more unit tests and give priority to syncing reclaim policy #169

merged 8 commits into from
Nov 8, 2018

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Nov 7, 2018

@tennix @onlymellb @xiaojingchen PTAL

@weekface
add more unit tests
749b9a6 
sync reclaim policy first
@weekface
Copy link
Contributor Author

weekface commented Nov 7, 2018

/run-unit-tests

@weekface
Copy link
Contributor Author

weekface commented Nov 7, 2018

/run-e2e-tests

tennix
tennix previously approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xiaojingchen
xiaojingchen reviewed Nov 7, 2018
View reviewed changes
Copy link
Contributor

@xiaojingchen xiaojingchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Update pkg/scheduler/predicates/ha_test.go
a19db8a 
Co-Authored-By: weekface <weekface@gmail.com>
@weekface weekface dismissed stale reviews from tennix via a19db8a November 7, 2018 08:01
@onlymellb
Copy link
Contributor

LGTM

tennix
tennix approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix
Copy link
Member

tennix commented Nov 8, 2018

/run-e2e-tests

@tennix
Copy link
Member

tennix commented Nov 8, 2018

/run-e2e-tests

@tennix tennix merged commit 7fbf8ac into pingcap:master Nov 8, 2018
@weekface weekface deleted the more-unit-tests-tidbcluster-control branch November 9, 2018 03:58
queenliuxx pushed a commit to queenliuxx/tidb-operator that referenced this pull request Dec 19, 2018
@weekface @tennix
add more unit tests and give priority to syncing reclaim policy (ping…
1ce7cf9 
…cap#169)

* add more unit tests
sync reclaim policy first

* Update pkg/scheduler/predicates/ha_test.go

Co-Authored-By: weekface <weekface@gmail.com>

* address comment
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@ran-huang @DanielZhangQD @lilin90
en: add notes for tidb-operator version (#169)
6619e84 
* en: add notes for tidb-operator version

* Apply suggestions from code review

Co-Authored-By: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

* apply suggestion to other two files

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlymellb onlymellb onlymellb left review comments

@tennix tennix tennix approved these changes

@xiaojingchen xiaojingchen xiaojingchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weekface @onlymellb @tennix @xiaojingchen