use {{ .Release.Name }} as cluster name #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weekface
reviewed
Nov 6, 2018
gregwebs
reviewed
Nov 6, 2018
xiaojingchen
previously approved these changes
Nov 7, 2018
weekface
previously approved these changes
Nov 7, 2018
|
/run-e2e-tests |
…-operator into use-release-name-for-cluster
|
/run-e2e-tests |
gregwebs
previously approved these changes
Nov 7, 2018
xiaojingchen
previously approved these changes
Nov 8, 2018
|
/run-e2e-tests |
weekface
approved these changes
Nov 8, 2018
xiaojingchen
approved these changes
Nov 8, 2018
queenliuxx
pushed a commit
to queenliuxx/tidb-operator
that referenced
this pull request
Dec 19, 2018
* use {{ .Release.Name }} as cluster name
* keep cluster name for resource names
* fix tests
* fix master merge conflict
fgksgf
pushed a commit
to fgksgf/tidb-operator
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GKE marketplace needs to set
{{ .Release.Name }}to its managed resources labels. But we don't have that in tidb-cluster resources. Helm [recommends] use{{ .Release.Name }}as instance label. We've already use instance labels for pod int tidb-operator codetidb-operator/pkg/label/label.go
Lines 32 to 34 in 4d0f6f9
To keep consistent, we should use release name for cluster name too.