e2e: meta sync #164
Merged
e2e: meta sync #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-tests |
|
/run-e2e-tests |
tennix
reviewed
Nov 7, 2018
| return false, nil | ||
| } | ||
| for _, member := range members.Members { | ||
| if member.Name == podName { |
There was a problem hiding this comment.
What if there is no member name matching pod name?
There was a problem hiding this comment.
tennix
reviewed
Nov 7, 2018
| } | ||
| for _, store := range stores.Stores { | ||
| addr := store.Store.GetAddress() | ||
| if strings.Split(addr, ".")[0] == podName { |
xiaojingchen
reviewed
Nov 7, 2018
| for _, vol := range pod.Spec.Volumes { | ||
| if vol.PersistentVolumeClaim != nil { | ||
| pvcName = vol.PersistentVolumeClaim.ClaimName | ||
| break |
There was a problem hiding this comment.
if the pod have multiple pvcs?
There was a problem hiding this comment.
currently, there are no multiple pvcs
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
xiaojingchen
approved these changes
Nov 8, 2018
queenliuxx
pushed a commit
to queenliuxx/tidb-operator
that referenced
this pull request
Dec 19, 2018
* e2e: meta sync
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
fgksgf
added a commit
to fgksgf/tidb-operator
that referenced
this pull request
Dec 23, 2024
Co-authored-by: Cody (Xuecheng) Zhang <csuzhangxc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds the e2e specs to ensure meta informations are synced properly.
@tennix @onlymellb @xiaojingchen PTAL