failover: emit events when pd failover (#1466) #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onlymellb
approved these changes
Jan 9, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for 1493, 1445, 1515, 1505 |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1466 to release-1.1
What problem does this PR solve?
fixes: #1465
This PR tries to emit three k8s
Events:PDMemberUnhealthy,PDMemberMarkedAsFailureandPDMemberDeletedto indicate the pdfailoverprocedure when the use typekubectl describe tc:But there is a problem that there are many not very useful
Events:SuccessfulUpdate, I will open another PR to remove them. @cofyc @aylei PTAL.What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: