Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some broken urls #1501

Merged
merged 3 commits into from
Jan 9, 2020
Merged

fix some broken urls #1501

merged 3 commits into from
Jan 9, 2020

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Jan 7, 2020

What problem does this PR solve?

What is changed and how does it work?

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

NONE

@Yisaer
Copy link
Contributor

Yisaer commented Jan 7, 2020 •
edited
Loading

docs-cn uses verify-link.sh` to check whether there are any links unaccessible in markdown file. Maybe we could add it into our CI checking process?

@weekface
Copy link
Contributor Author

weekface commented Jan 7, 2020

I think it is not necessary to check automatically now, veryfy-link.sh use markdown-link-check, values.yaml is YAML format however.

aylei
aylei approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor

aylei commented Jan 8, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 8, 2020

Your auto merge job has been accepted, waiting for 1486, 1466, 1405

@sre-bot
Copy link
Contributor

sre-bot commented Jan 8, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 8, 2020

@weekface merge failed.

@cofyc
Copy link
Contributor

cofyc commented Jan 8, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 8, 2020

Your auto merge job has been accepted, waiting for 1493, 1491, 1506

@sre-bot
Copy link
Contributor

sre-bot commented Jan 8, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 8, 2020

@weekface merge failed.

@cofyc
Copy link
Contributor

cofyc commented Jan 9, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

/run-all-tests

@sre-bot sre-bot merged commit 67ce569 into pingcap:master Jan 9, 2020
@sre-bot sre-bot mentioned this pull request Jan 9, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

cherry pick to release-1.1 in PR #1515

@weekface weekface deleted the fix-broken-url branch January 9, 2020 05:54
@weekface weekface mentioned this pull request Jan 9, 2020
Merged
sre-bot added a commit that referenced this pull request Jan 9, 2020
@sre-bot
fix some broken urls (#1501) (#1515)
445f631
sre-bot added a commit to weekface/tidb-operator that referenced this pull request Jan 15, 2020
@sre-bot
Merge branch 'release-1.0' into automated-cherry-pick-of-pingcap#1501-…
21b976f 
…release-1.0
sre-bot pushed a commit that referenced this pull request Jan 15, 2020
@weekface @sre-bot
Automated cherry pick of #1501: fix some broken urls (#1519)
0743604
yahonda added a commit that referenced this pull request Dec 27, 2021
@yahonda
Replace `shell with `bash
c8496eb 
Fix #1501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aylei aylei aylei approved these changes

@cofyc cofyc cofyc approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-1.1 status/can-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@weekface @Yisaer @aylei @sre-bot @cofyc