Add default behavior in config field description #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aylei
requested review from
LinuxGit,
sdojjy,
tennix,
Yisaer and
shuijing198799
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-all-test |
LinuxGit
reviewed
Dec 26, 2019
LinuxGit
reviewed
Dec 26, 2019
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/merge |
|
/run-all-tests |
|
/run-all-tests |
|
@aylei merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aylei rayingecho@gmail.com
What problem does this PR solve?
close #986
What is changed and how does it work?
ValidateUpdateerror in the later validation logicNote that we don't use
// +kubebuilder:default=xxxcomment tag to set defaults of the configuration because the TiKV/PD/TiDB server will automatically perform the behavior when the fields are omitted and we want to keep the spec of TidbCluster simple.Check List
Tests
Does this PR introduce a user-facing change?:
@shuijing198799 @sdojjy @tennix @Yisaer @LinuxGit PTAL