Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing TiKV config #1388

Merged
merged 3 commits into from
Dec 20, 2019
Merged

Add missing TiKV config #1388

merged 3 commits into from
Dec 20, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Dec 20, 2019

This fix #1306 by adding the missing fields.

This commit 88c9fe4 contains code changes without code-generation.

@sdojjy @LinuxGit @Yisaer @DanielZhangQD PTAL

Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei
Copy link
Contributor Author

aylei commented Dec 20, 2019

/run-e2e-test

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LinuxGit LinuxGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor Author

aylei commented Dec 20, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

@aylei merge failed.

@aylei
Copy link
Contributor Author

aylei commented Dec 20, 2019

/merge

@aylei
Copy link
Contributor Author

aylei commented Dec 20, 2019

/run-auto-merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2019

/run-all-tests

@sre-bot sre-bot merged commit d104613 into pingcap:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants