Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick hostnetwork support (#774) to release-1.0 #1202

Merged
merged 5 commits into from
Nov 21, 2019

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented Nov 20, 2019

What problem does this PR solve?

fixes #1201

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test

@cofyc
Copy link
Contributor Author

cofyc commented Nov 20, 2019

/run-e2e-test

@cofyc
Copy link
Contributor Author

cofyc commented Nov 20, 2019

/run-e2e-test

1 similar comment
@cofyc
Copy link
Contributor Author

cofyc commented Nov 21, 2019

/run-e2e-test

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor

aylei commented Nov 21, 2019

@weekface @tennix PTAL

@aylei aylei modified the milestones: v1.1.0, v1.0.4 Nov 21, 2019
@aylei
Copy link
Contributor

aylei commented Nov 21, 2019

@cofyc e2e passed, is this still WIP?

@cofyc cofyc changed the title WIP: Cherry-pick hostnetwork support (#774) to release-1.0 Cherry-pick hostnetwork support (#774) to release-1.0 Nov 21, 2019
@cofyc cofyc merged commit 6b7bd19 into pingcap:release-1.0 Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants