unit tests for hostnetwork and run e2e test conditionally #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-test |
cofyc
commented
Nov 1, 2019
| @@ -426,7 +426,7 @@ func (pmm *pdMemberManager) pdStatefulSetIsUpgrading(set *apps.StatefulSet, tc * | |||
| return false, nil | |||
| } | |||
|
|
|||
| func (pmm *pdMemberManager) getNewPDSetForTidbCluster(tc *v1alpha1.TidbCluster) (*apps.StatefulSet, error) { | |||
| func getNewPDSetForTidbCluster(tc *v1alpha1.TidbCluster) (*apps.StatefulSet, error) { | |||
There was a problem hiding this comment.
function receiver is removed because not needed
cofyc
commented
Nov 1, 2019
| @@ -219,7 +219,7 @@ func getNewTiDBHeadlessServiceForTidbCluster(tc *v1alpha1.TidbCluster) *corev1.S | |||
| } | |||
| } | |||
|
|
|||
| func (tmm *tidbMemberManager) getNewTiDBSetForTidbCluster(tc *v1alpha1.TidbCluster) *apps.StatefulSet { | |||
| func getNewTiDBSetForTidbCluster(tc *v1alpha1.TidbCluster) *apps.StatefulSet { | |||
There was a problem hiding this comment.
function receiver is removed because not needed
cofyc
commented
Nov 1, 2019
| @@ -269,7 +269,7 @@ func getNewServiceForTidbCluster(tc *v1alpha1.TidbCluster, svcConfig SvcConfig) | |||
| return &svc | |||
| } | |||
|
|
|||
| func (tkmm *tikvMemberManager) getNewSetForTidbCluster(tc *v1alpha1.TidbCluster) (*apps.StatefulSet, error) { | |||
| func getNewTiKVSetForTidbCluster(tc *v1alpha1.TidbCluster) (*apps.StatefulSet, error) { | |||
There was a problem hiding this comment.
function receiver is removed because not needed, easier to test
|
/run-e2e-test |
cofyc
commented
Nov 1, 2019
| (sv.AtLeast(utilversion.MustParseSemantic("v1.15.0")) && sv.LessThan(utilversion.MustParseSemantic("v1.15.4"))) { // >= v1.15.0 but < v1.15.4 | ||
| // https://github.com/pingcap/tidb-operator/issues/1042#issuecomment-547742565 | ||
| glog.Infof("Skipping HostNetwork test. Kubernetes %v has a bug that StatefulSet may apply revision incorrectly, HostNetwork cannot work well in this cluster", serverVersion) | ||
| return |
There was a problem hiding this comment.
example log:
[2019-11-01T03:35:11.775Z] I1101 03:35:09.611526 1 main.go:181] ServerVersion: v1.12.10
[2019-11-01T03:35:11.775Z] I1101 03:35:09.611549 1 main.go:186] Skipping HostNetwork test. Kubernetes v1.12.10 has a bug that StatefulSet may apply revision incorrectly, HostNetwork cannot work well in this cluster
cofyc
requested review from
Yisaer,
weekface,
tennix,
onlymellb and
DanielZhangQD
and removed request for
Yisaer
cofyc
commented
Nov 1, 2019
| @@ -172,6 +173,20 @@ func main() { | |||
| * Note that only one cluster can run in host network mode at the same time. | |||
| */ | |||
| testHostNetwork := func(wg *sync.WaitGroup, cluster *tests.TidbClusterConfig) { | |||
| serverVersion, err := kubeCli.Discovery().ServerVersion() | |||
| if err != nil { | |||
| panic(err) | |||
There was a problem hiding this comment.
exit if the cluster is unavailable or unstable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #1042
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: