Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv failover may cause scale in failure in some cases #725

Closed
onlymellb opened this issue Aug 1, 2019 · 0 comments · Fixed by #726
Closed

tikv failover may cause scale in failure in some cases #725

onlymellb opened this issue Aug 1, 2019 · 0 comments · Fixed by #726
Assignees
@onlymellb

Comments

@onlymellb
Copy link
Contributor

Bug Report

What version of Kubernetes are you using?

v1.12
What version of TiDB Operator are you using?

the latest release version
What storage classes exist in the Kubernetes cluster and what are used for PD/TiKV pods?

What's the status of the TiDB cluster pods?

What did you do?

  1. Prepare a k8s cluster that can only deploy three tikv instances
  2. Simulate a tikv instance failure and let the operator perform a failover operation
  3. At this point, the fourth tikv instance added by failover is the pending status
  4. Restore the previous tikv instance and then set the tidbcluster's .Status.TiKV.FailureStores to empty

What did you expect to see?
When set the .Status.TiKV.FailureStores to empty, tidb-operator should scale in the tikv instances to the original value set by a user

What did you see instead?
The number of tikv instances is still four, not scale in three
@onlymellb onlymellb self-assigned this Aug 1, 2019
@onlymellb onlymellb changed the title tikv failover may cause scale in to fail in some cases tikv failover may cause scale in failure in some cases Aug 1, 2019
@onlymellb onlymellb mentioned this issue Aug 1, 2019
Merged
@sre-bot sre-bot mentioned this issue Aug 8, 2019
Merged
yahonda pushed a commit that referenced this issue Dec 27, 2021
@ran-huang
[testing].github: add an action to auto label stale issues (#725)
0e3827c 
* .github: add an action to auto label stale issues

Signed-off-by: Ran <huangran@pingcap.com>

* tiny update

Signed-off-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onlymellb onlymellb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tikv scale in failure in some cases onlymellb/tidb-operator
1 participant
@onlymellb