Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigMapRollout should retain the last used configmap #603

Closed
aylei opened this issue Jun 21, 2019 · 3 comments
Closed

ConfigMapRollout should retain the last used configmap #603

aylei opened this issue Jun 21, 2019 · 3 comments
Assignees
@aylei
Labels
enhancement New feature or request type/bug Something isn't working

Comments

@aylei
Copy link
Contributor

aylei commented Jun 21, 2019

Bug Report

What version of Kubernetes are you using?

1.12.6

What version of TiDB Operator are you using?

latest

What did you do?

Deploy a cluster with configmap rollout disabled, then enable configmap rollout.

What did you see instead?

Warning  FailedMount  27s (x10 over 4m37s)  kubelet, gke-benchmark-190621-default-pool-ca620099-brgp  MountVolume.SetUp failed for volume "startup-script" : configmaps "bench-tikv" not found

At first, tikv-0 is pending because the PV has not bean created, then configmap rollout enabled, but tikv-0 is still pending so it cannot be updated to the new revision. Then the PV created, tikv-0 tries to start but the configmap of old revision is not existed.

We should ensure that ConfigMapRollout retains the last used configmap.
@aylei aylei added the type/bug Something isn't working label Jun 21, 2019
@aylei aylei self-assigned this Jun 21, 2019
@weekface weekface added the enhancement New feature or request label Jul 15, 2019
@weekface weekface added this to the v1.1 milestone Jul 16, 2019
@DanielZhangQD
Copy link
Contributor

For this case, we may have to retain all versions, we cannot know exactly how many times the cm has been rolled out before PV ready.

@tennix tennix removed this from the v1.1.0 milestone Oct 10, 2019
@aylei
Copy link
Contributor Author

aylei commented Oct 15, 2019

Hopefully, this will be addressed in #986

@aylei
Copy link
Contributor Author

aylei commented Dec 19, 2019

closed via #1121

@aylei aylei closed this as completed Dec 19, 2019
yahonda pushed a commit that referenced this issue Dec 27, 2021
@ran-huang @lilin90
en: add how to delete backup cr (#603)
f52318e 
* en: add how to delete backup cr

Signed-off-by: Ran <huangran@pingcap.com>

* align with #523

Signed-off-by: Ran <huangran@pingcap.com>

* Update en/deploy-on-aws-eks.md

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Co-authored-by: Lilian Lee <lilin@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aylei aylei

Labels
enhancement New feature or request type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@weekface @tennix @aylei @DanielZhangQD