Address review comments

Signed-off-by: Aylei <rayingecho@gmail.com>
pingcap · Apr 17, 2019 · 919bae6 · 919bae6
1 parent 7e3e4fa
commit 919bae6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/tests/backup/backupcase.go b/tests/backup/backupcase.go
@@ -38,14 +38,14 @@ func NewBackupCase(operator tests.OperatorActions, srcCluster *tests.TidbCluster
 func (bc *BackupCase) Run() error {
 
 	// pause write pressure during backup
+	bc.operator.StopInsertDataTo(bc.srcCluster)
 	defer func() {
 		go func() {
 			if err := bc.operator.BeginInsertDataTo(bc.srcCluster); err != nil {
 				glog.Errorf("cluster:[%s] begin insert data failed,error: %v", bc.srcCluster.ClusterName, err)
 			}
 		}()
 	}()
-	bc.operator.StopInsertDataTo(bc.srcCluster)
 
 	err := bc.operator.DeployAdHocBackup(bc.srcCluster)
 	if err != nil {

diff --git a/tests/cmd/stability/main.go b/tests/cmd/stability/main.go
@@ -156,12 +156,10 @@ func main() {
 	oa.CheckTidbClusterStatusOrDie(cluster1)
 	oa.CheckTidbClusterStatusOrDie(cluster2)
 
-	defer func() {
-		oa.StopInsertDataTo(cluster1)
-		oa.StopInsertDataTo(cluster2)
-	}()
 	go oa.BeginInsertDataToOrDie(cluster1)
+	defer oa.StopInsertDataTo(cluster1)
 	go oa.BeginInsertDataToOrDie(cluster2)
+	defer oa.StopInsertDataTo(cluster2)
 
 	// TODO add DDL
 	//var workloads []workload.Workload