This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
status/WIP
Work in progress
priority/important
type/bug-fix
Bug fix
3.0-release-note
Should include in release note for next 3.0 release. Remove after release.
3.1-release-note
Should include in release note for next 3.1 release. Remove after release.
4.0-release-note
Should include in release note for next 4.0 release. Remove after release.
labels
Mar 16, 2020
kennytm
force-pushed
the
kennytm/fix-282
branch
from
March 16, 2020 06:40
4a2e2c2
to
789c94e
Compare
kennytm
added
status/PTAL
This PR is ready for review. Add this label back after committing new changes
and removed
status/WIP
Work in progress
labels
Mar 16, 2020
/run-all-tests |
LGTM |
IANTHEREAL
added
status/LGT1
One reviewer already commented LGTM (LGTM1)
and removed
status/PTAL
This PR is ready for review. Add this label back after committing new changes
labels
Mar 16, 2020
kennytm
force-pushed
the
kennytm/fix-282
branch
from
March 16, 2020 09:20
03bea7c
to
7a16c90
Compare
PTAL @leoppro |
zier-one
approved these changes
Mar 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3.0-release-note
Should include in release note for next 3.0 release. Remove after release.
3.1-release-note
Should include in release note for next 3.1 release. Remove after release.
4.0-release-note
Should include in release note for next 4.0 release. Remove after release.
status/LGT1
One reviewer already commented LGTM (LGTM1)
type/bug-fix
Bug fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixed #282, caused by a typo.
What is changed and how it works?
Previously
\Z
was treated as\x26
(which is&
). It should be\x1a
(decimal 26).Check List
Tests
Side effects
Related changes
&
is replaced by EOF character in TiDB backend.\Z
is replaced by&
.