This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
Make sure the session param takes effect #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note the previous `setSessionConcurrencyVars` will set one connection from the db connection pool, so we can't make sure the session will take affect later using the `sql.DB`.
july2993
added
the
status/PTAL
july2993
added
status/LGT1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Make sure the session param takes effect.
What is changed and how it works?
Set session var for every new conn. For every new connection created by the driver, it will set the params first.
Note the previous
setSessionConcurrencyVarswill set one connectionfrom the db connection pool, so we can't make sure the session will take
effect later using the
sql.DB.Check List
Tests
check tidb log for the session params setted using the dsn.
Side effects
Related changes
Need to cherry-pick to the release branch
Need to be included in the release note