This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
config: attempt to solve TOOL-1405 and modify old test cases #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
changed the title
lance6716
added
feature-request
zier-one
reviewed
Jul 23, 2019
|
/run-all-tests |
|
LGTM |
|
/run-all-tests |
kennytm
added
status/LGT1
|
/run-all-tests |
kennytm
reviewed
Jul 24, 2019
|
/run-all-tests |
Co-Authored-By: kennytm <kennytm@gmail.com>
|
/run-all-tests |
kennytm
approved these changes
Jul 25, 2019
lance6716
added
status/LGT2
kennytm
removed
the
Should Update Docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Early exit to save time when user's toml config contains unused items, for example, a typo. And give warnings when some config items won't take effect.
What is changed and how it works?
A check is performed on
(*Config).LoadFromTOML, usingtoml.DecodeandmetaData.Undecodedto detect unused toml keys. Considering we have two structureConfigandGlobalConfig, we check for both unused keys and give according exit-action or warning.Check List
Tests
Side effects
Related changes