This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 66
restore: give priority to small tables for importing #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonng
force-pushed
the
lonng/priority-sched
branch
from
March 28, 2019 04:59
397ee51
to
77f338d
Compare
kennytm
added
status/DNM
Do not merge, test is failing or blocked by another PR
priority/important
type/enhancement
Performance improvement or refactoring
labels
Mar 28, 2019
Please rebase on the latest master (if you still want to proceed on this PR). |
lonng
force-pushed
the
lonng/priority-sched
branch
from
April 4, 2019 02:22
77f338d
to
204b718
Compare
lonng
changed the title
restore: give priority to large tables for importing
restore: give priority to small tables for importing
Apr 4, 2019
kennytm
removed
the
status/DNM
Do not merge, test is failing or blocked by another PR
label
Apr 7, 2019
kennytm
reviewed
Apr 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM.
Co-Authored-By: lonng <chris@lonng.org>
PTAL @GregoryIan @kennytm |
kennytm
reviewed
Apr 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
lonng
added
status/LGT2
Two reviewers already commented LGTM, ready for merge (LGTM2)
and removed
status/LGT1
One reviewer already commented LGTM (LGTM1)
labels
Apr 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
status/LGT2
Two reviewers already commented LGTM, ready for merge (LGTM2)
type/enhancement
Performance improvement or refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Put the large table in the front of the slice which can avoid large table take a long time to import and block small table to release index worker.
What is changed and how it works?
Sorting tables before restore.
Check List
Tests
Side effects
N/A
Related changes
N/A