Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

Commit

Permalink
*: addressed comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kennytm committed Jan 3, 2019
1 parent 294f228 commit a2274b8
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 6 deletions.
4 changes: 2 additions & 2 deletions lightning/kv/importer.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ func makeTag(tableName string, engineID int) string {

var engineNamespace = uuid.Must(uuid.FromString("d68d6abe-c59e-45d6-ade8-e2b0ceb7bedf"))

// OpenEngine opens an engine with the given UUID. This type is goroutine safe:
// you can share this instance and execute any method anywhere.
// OpenEngine opens an engine with the given table name and engine ID. This type
// is goroutine safe: you can share this instance and execute any method anywhere.
func (importer *Importer) OpenEngine(
ctx context.Context,
tableName string,
Expand Down
2 changes: 1 addition & 1 deletion tests/checkpoint_engines/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ addr = "127.0.0.1:8808"

[mydumper]
data-source-dir = "tests/checkpoint_engines/data"
batch-size = 1 # force creating a new batch for every file.
batch-size = 60 # force splitting the data into 4 batches

[tidb]
host = "127.0.0.1"
Expand Down
2 changes: 1 addition & 1 deletion tests/checkpoint_engines/data/cpeng.a.1.sql
Original file line number Diff line number Diff line change
@@ -1 +1 @@
insert into a values (1),(2);
insert into a values (1);
2 changes: 1 addition & 1 deletion tests/checkpoint_engines/data/cpeng.a.2.sql
Original file line number Diff line number Diff line change
@@ -1 +1 @@
insert into a values (3),(4);
insert into a values (2);
1 change: 1 addition & 0 deletions tests/checkpoint_engines/data/cpeng.a.3.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
insert into a values (3),(4);
3 changes: 3 additions & 0 deletions tests/checkpoint_engines/data/cpeng.b.1.sql
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
insert into b values (10),(11),(12);
/*
padding to make the data file > 50 bytes
*/
2 changes: 1 addition & 1 deletion tests/checkpoint_engines/mysql.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ addr = "127.0.0.1:8808"

[mydumper]
data-source-dir = "tests/checkpoint_engines/data"
batch-size = 1 # force creating a new batch for every file.
batch-size = 50 # force splitting the data into 4 batches

[tidb]
host = "127.0.0.1"
Expand Down

0 comments on commit a2274b8

Please sign in to comment.