Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hide resource manager and overview monitoring for clinic cloud #1590

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Sep 12, 2023

Preview

screenshot-20230912-164835

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit ac8b370
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/65002822f19a9600085e78e1
😎 Deploy Preview https://deploy-preview-1590--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #1590 (ac8b370) into master (f1e012a) will increase coverage by 1.69%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1590      +/-   ##
==========================================
+ Coverage   24.71%   26.41%   +1.69%     
==========================================
  Files         169       97      -72     
  Lines       15211    10450    -4761     
==========================================
- Hits         3759     2760     -999     
+ Misses      11170     7505    -3665     
+ Partials      282      185      -97     
Flag Coverage Δ
backend_integration ?
backend_ut 26.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e012a...ac8b370. Read the comment docs.

@baurine baurine force-pushed the chore/hide-resource-manager-for-clinic branch from d7ebd70 to ac8b370 Compare September 12, 2023 08:58
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2023

@SabaPing: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SabaPing
Once this PR has been reviewed and has the lgtm label, please ask for approval from baurine. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baurine baurine merged commit 65de997 into master Sep 12, 2023
12 of 17 checks passed
@baurine baurine deleted the chore/hide-resource-manager-for-clinic branch September 12, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants