Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: tweak: allows prom addr with http path (#1563) #1571

Closed
wants to merge 1 commit into from

Conversation

mornyx
Copy link
Collaborator

@mornyx mornyx commented Aug 14, 2023

cherry pick #1563

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign crazycs520 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from Renkai August 14, 2023 07:33
@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for tidb-dashboard failed.

Name Link
🔨 Latest commit d6e3aea
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/64d9d8c2be85c80008853d23

@ti-chi-bot ti-chi-bot bot added the size/S label Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release@c088112). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             release    #1571   +/-   ##
==========================================
  Coverage           ?   24.76%           
==========================================
  Files              ?      168           
  Lines              ?    14998           
  Branches           ?        0           
==========================================
  Hits               ?     3714           
  Misses             ?    11010           
  Partials           ?      274           
Flag Coverage Δ
backend_integration 9.03% <0.00%> (?)
backend_ut 26.78% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c088112...d6e3aea. Read the comment docs.

@mornyx mornyx closed this Aug 14, 2023
@mornyx mornyx deleted the release-6.5 branch August 14, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant