tweak: allows custom names to pass tls verification #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mornyx <mornyx.z@gmail.com>
❌ Deploy Preview for tidb-dashboard-for-dbaas failed.
|
❌ Deploy Preview for tidb-dashboard failed.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1562 +/- ##
===========================================
+ Coverage 9.03% 24.72% +15.69%
===========================================
Files 122 168 +46
Lines 12708 14998 +2290
===========================================
+ Hits 1148 3709 +2561
+ Misses 11439 11018 -421
- Partials 121 271 +150
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
baurine
approved these changes
Jul 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baurine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
baurine
pushed a commit
that referenced
this pull request
Aug 15, 2023
baurine
added a commit
that referenced
this pull request
Aug 16, 2023
* chore: fix prometheus typo (#1558) * fix(manual-profiling): fix crash caused by undefined filed `raw_data_type` (#1559) * chore: remove slow query v2 pages (#1530) * chore: remove slow query v2 pages * chore: remove @antv/g2plot dep * tweak: allows custom names to pass tls verification (#1562) * tweak: allows prom addr with http path (#1563) * fix: add endpoint verification in debugapi to avoid ssrf (#1564) * feat: allows ngm timeout to be configured (#1569) * fix(statements): fix download statements failed issue * update version to 2023.08.15.1 --------- Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #1139