fix check dashboard privileges error (#1018)

pingcap · Oct 8, 2021 · 343fccf · 343fccf
1 parent f1cd99c
commit 343fccf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/apiserver/user/verify_sql_user.go b/pkg/apiserver/user/verify_sql_user.go
@@ -120,7 +120,7 @@ func checkDashboardPriv(privs map[string]struct{}, enableSEM bool) bool {
 		if !hasPriv("RESTRICTED_TABLES_ADMIN", privs) {
 			return false
 		}
-		if !hasPriv("RESTRICTED_TABLES_ADMIN", privs) {
+		if !hasPriv("RESTRICTED_STATUS_ADMIN", privs) {
 			return false
 		}
 	}

diff --git a/pkg/apiserver/user/verify_sql_user_test.go b/pkg/apiserver/user/verify_sql_user_test.go
@@ -151,14 +151,14 @@ func (t *testVerifySQLUserSuite) Test_checkDashboardPriv(c *C) {
 		// 8
 		{
 			desc:      "extra privileges",
-			grants:    []string{"PROCESS", "SHOW DATABASES", "CONFIG", "DASHBOARD_CLIENT", "RESTRICTED_VARIABLES_ADMIN", "RESTRICTED_TABLES_ADMIN", "RESTRICTED_TABLES_ADMIN"},
+			grants:    []string{"PROCESS", "SHOW DATABASES", "CONFIG", "DASHBOARD_CLIENT", "RESTRICTED_VARIABLES_ADMIN", "RESTRICTED_TABLES_ADMIN", "RESTRICTED_STATUS_ADMIN"},
 			enableSEM: true,
 			expected:  true,
 		},
 		// 9
 		{
 			desc:      "lack RESTRICTED_VARIABLES_ADMIN extra privileges",
-			grants:    []string{"PROCESS", "SHOW DATABASES", "CONFIG", "DASHBOARD_CLIENT", "RESTRICTED_TABLES_ADMIN", "RESTRICTED_TABLES_ADMIN"},
+			grants:    []string{"PROCESS", "SHOW DATABASES", "CONFIG", "DASHBOARD_CLIENT", "RESTRICTED_TABLES_ADMIN", "RESTRICTED_STATUS_ADMIN"},
 			enableSEM: true,
 			expected:  false,
 		},