chore(binary-plan): truncate long operator info for execution plan (#…

…1565)
pingcap · Sep 11, 2023 · 32ee1bb · 32ee1bb
1 parent c7ccb33
commit 32ee1bb
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 5 deletions.
diff --git a/ui/packages/tidb-dashboard-client/src/client/api/models/slowquery-model.ts b/ui/packages/tidb-dashboard-client/src/client/api/models/slowquery-model.ts
@@ -207,7 +207,7 @@ export interface SlowqueryModel {
      */
     'parse_time'?: number;
     /**
-     * 
+     * deprecated, replaced by BinaryPlanText
      * @type {string}
      * @memberof SlowqueryModel
      */

diff --git a/ui/packages/tidb-dashboard-client/src/client/api/models/statement-model.ts b/ui/packages/tidb-dashboard-client/src/client/api/models/statement-model.ts
@@ -405,7 +405,7 @@ export interface StatementModel {
      */
     'min_latency'?: number;
     /**
-     * 
+     * deprecated, replaced by BinaryPlanText
      * @type {string}
      * @memberof StatementModel
      */

diff --git a/ui/packages/tidb-dashboard-client/swagger/spec.json b/ui/packages/tidb-dashboard-client/swagger/spec.json
@@ -4993,6 +4993,7 @@
                     "type": "number"
                 },
                 "plan": {
+                    "description": "deprecated, replaced by BinaryPlanText",
                     "type": "string"
                 },
                 "plan_from_binding": {
@@ -5425,6 +5426,7 @@
                     "type": "integer"
                 },
                 "plan": {
+                    "description": "deprecated, replaced by BinaryPlanText",
                     "type": "string"
                 },
                 "plan_can_be_bound": {

diff --git a/ui/packages/tidb-dashboard-lib/src/client/models.ts b/ui/packages/tidb-dashboard-lib/src/client/models.ts
@@ -2345,7 +2345,7 @@ export interface SlowqueryModel {
      */
     'parse_time'?: number;
     /**
-     * 
+     * deprecated, replaced by BinaryPlanText
      * @type {string}
      * @memberof SlowqueryModel
      */
@@ -3145,7 +3145,7 @@ export interface StatementModel {
      */
     'min_latency'?: number;
     /**
-     * 
+     * deprecated, replaced by BinaryPlanText
      * @type {string}
      * @memberof StatementModel
      */

diff --git a/ui/packages/tidb-dashboard-lib/src/components/BinaryPlanTable/index.tsx b/ui/packages/tidb-dashboard-lib/src/components/BinaryPlanTable/index.tsx
@@ -205,7 +205,14 @@ export const BinaryPlanTable: React.FC<BinaryPlanTableProps> = ({ data }) => {
         minWidth: 100,
         maxWidth: 300,
         onRender: (row: BinaryPlanItem) => {
-          return <Tooltip title={row.operatorInfo}>{row.operatorInfo}</Tooltip>
+          // truncate the string if it's too long
+          // operation info may be super super long
+          const truncateLength = 1000
+          let truncatedStr = row.operatorInfo
+          if (truncatedStr.length > truncateLength) {
+            truncatedStr = row.operatorInfo.slice(0, truncateLength) + '...'
+          }
+          return <Tooltip title={row.operatorInfo}>{truncatedStr}</Tooltip>
         }
       },
       {