Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support go time package format gc time (#996) #998

Conversation

lichunzhu
Copy link
Contributor

cherry-pick #996 to release-4.0


What problem does this PR solve?

resolve #994

What is changed and how it works?

Support gc time for "8m", "7h". If no unit is specified, gc duration will use day as unit as before.

It should be noticed that the max time duration unit that supported in golang is hour "h".
golang/go#11473
golang/go#17767

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

Release note

  • support go time duration format for pump GC configuration

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu lichunzhu changed the title cherry-pick supportGoTimeFormatGCConfig support go time package format gc time (#996) Aug 10, 2020
@july2993
Copy link
Contributor

for 4.0 I will merge master directly for no diverse

@july2993 july2993 closed this Aug 10, 2020
@lichunzhu lichunzhu deleted the cherry4.0/supportGoTimeFormatGCConfig branch August 10, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants