Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not using tls when saving checkpoint #988

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Fix not using tls when saving checkpoint #988

merged 2 commits into from
Jul 20, 2020

Conversation

july2993
Copy link
Contributor

@july2993 july2993 commented Jul 20, 2020

What problem does this PR solve?

Fix not using tls when saving checkpoint.

when syncer.to.security is enable.
the db create for replicating data will enable tls, but the db for saving checkpoint is not.

What is changed and how it works?

enable tls for the db saving checkpoint too.

Check List

Release note

  • Fix not using TLS when saving checkpoint

@july2993
Copy link
Contributor Author

/run-all-tests

lichunzhu
lichunzhu previously approved these changes Jul 20, 2020
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993
Copy link
Contributor Author

/run-unit-test

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 merged commit fb0cc0d into master Jul 20, 2020
@july2993 july2993 deleted the fix_cp_tls branch July 20, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants