Optimize the performance of bidirectional synchronous update table of _drainer_repl_mark #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of _drainer_repl_mark
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests |
|
LGTM, @july2993 PTAL |
|
/run-all-tests |
july2993
reviewed
Feb 21, 2020
| var args []interface{} | ||
| sql := fmt.Sprintf("update %s set %s=%s+1 where %s=? and %s=? limit 1;", loopbacksync.MarkTableName, loopbacksync.Val, loopbacksync.Val, loopbacksync.ID, loopbacksync.ChannelID) | ||
| args = append(args, e.addIndex(), e.info.ChannelID) | ||
| _, err1 := tx.autoRollbackExec(sql, args...) |
There was a problem hiding this comment.
maybe we can check the affect rows to make sure we do update some row?
pkg/loader/executor.go
Outdated
| for id := 0; id < e.workerCount; id++ { | ||
| args = append(args, id, e.info.ChannelID, status, channel) | ||
| } | ||
| tx, err := e.begin() |
There was a problem hiding this comment.
in e.begin() it will updateMark it's confusing doing this.
suggest writing a func to accepte a *sql.DB directly to initMarkTable
july2993
approved these changes
Feb 24, 2020
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #909 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
1.Optimize the performance of bidirectional synchronous update table of _drainer_repl_mark
What is changed and how it works?
The number of channel related records in the mark table is initialized according to the number of worker "count. During synchronization, each syncer operates one piece of data, which will not cause multithreading to update one record, resulting in synchronization performance bottleneck of mark table.
Check List
Tests
Code changes
Side effects
Related changes
tidb-ansiblerepository