storage.go: Make query tikv for ddl too #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests tidb=release-3.0 tikv=release-3.0 pd=release-3.0 |
2 similar comments
|
/run-all-tests tidb=release-3.0 tikv=release-3.0 pd=release-3.0 |
|
/run-all-tests tidb=release-3.0 tikv=release-3.0 pd=release-3.0 |
|
/run-all-tests tidb=release-3.0 tikv=release-3.0 pd=release-3.0 |
IANTHEREAL
reviewed
Sep 29, 2019
Co-Authored-By: Ian <ArGregoryIan@gmail.com>
IANTHEREAL
reviewed
Sep 29, 2019
pump/storage/storage.go
Outdated
| return true | ||
| err = a.metadata.Put(encodeTSKey(req.ts()), pointer, nil) | ||
| if err != nil { | ||
| log.Error("put into metadata failed", zap.Error(req.err)) |
There was a problem hiding this comment.
Suggested change
| log.Error("put into metadata failed", zap.Error(req.err)) | |
| log.Error("put missing binlog into metadata failed", zap.Int64("start ts", startTS), | |
| zap.Uint64("commit ts", status.CommitTS()), | |
| zap.Bool("isDDL", pbinlog.GetDdlJobId() > 0)), | |
| zap.Error(req.err)) |
|
Rest LGTM |
|
/run-all-tests tidb=release-3.0 tikv=release-3.0 pd=release-3.0 |
1 similar comment
|
/run-all-tests tidb=release-3.0 tikv=release-3.0 pd=release-3.0 |
|
/run-all-tests tidb=release-3.0 tikv=release-3.0 pd=release-3.0 |
|
/rebuild |
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
|
/run-all-tests tidb=release-3.0 tikv=release-3.0 pd=release-3.0 |
july2993
added
needs-cherry-pick-release-2.1
status/LGT2
and removed
status/LGT1
labels
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Call CleanUp cmp for ddl binlog too.
may get the txn status from tikv or skip the binlog.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes