Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine BIT test & Fix arbiter bug(#667 & #714) #740

Merged

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

cherry-pick #667 and #714

What is changed and how it works?

  1. Delete tests/update_bit1 and add bit test case to /tests/dailytest/case.go to test drainer -> mysql and drainer -> kafka -> mysql.
  2. Fix arbiter quit bug.

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

@lichunzhu
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@july2993
Copy link
Contributor

july2993 commented Sep 9, 2019

@suzaku PTAL

Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993
Copy link
Contributor

july2993 commented Sep 9, 2019

/run-all-tests

@july2993 july2993 merged commit 1c18a1c into pingcap:release-2.1 Sep 9, 2019
@lichunzhu lichunzhu deleted the czli/release2.1/cherrypick667 branch September 9, 2019 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants