Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.1] drainer: fix failure to update BIT columns with downstream TiDB (#655) #657

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Jul 1, 2019

What problem does this PR solve?

Cherry-pick #655 to release-2.1.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

@kennytm kennytm requested review from suzaku and july2993 July 1, 2019 09:36
@kennytm kennytm changed the title drainer: fix failure to update BIT columns with downstream TiDB (#655) [release-2.1] drainer: fix failure to update BIT columns with downstream TiDB (#655) Jul 1, 2019
@kennytm
Copy link
Contributor Author

kennytm commented Jul 1, 2019

/rebuild

1 similar comment
@suzaku
Copy link
Contributor

suzaku commented Jul 1, 2019

/rebuild

Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm
Copy link
Contributor Author

kennytm commented Jul 1, 2019

/rebuild

@kennytm
Copy link
Contributor Author

kennytm commented Jul 1, 2019

/run-all-tests tidb=release-2.1 tikv=release-2.1 pd=release-2.1

Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 merged commit 76433a7 into release-2.1 Jul 2, 2019
@july2993 july2993 deleted the kennytm/fix-1346-for-2.1 branch July 2, 2019 02:22
@kennytm
Copy link
Contributor Author

kennytm commented Jul 2, 2019

Do we need a separate 3.0 backport or is it going to be a simple fast-forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants