pump/: Fix get L0 files num and trigger vlog.gcTS step by step #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1, Add a API to trigger gc 2, Check L0 files by *GetProperty* instead of Stats Stats can't get the right L0 files num, see: https://github.com/syndtr/goleveldb/pull/283/files 3, call vlog.gcTS step by step, help free space quickly
|
/run-all-tests |
IANTHEREAL
reviewed
Jun 24, 2019
IANTHEREAL
reviewed
Jun 24, 2019
IANTHEREAL
reviewed
Jun 24, 2019
IANTHEREAL
reviewed
Jun 24, 2019
IANTHEREAL
reviewed
Jun 24, 2019
suzaku
reviewed
Jun 24, 2019
july2993
changed the title
|
/run-all-tests |
IANTHEREAL
reviewed
Jun 26, 2019
| @@ -654,6 +663,10 @@ func (a *Append) doGCTS(ts int64) { | |||
| } | |||
| break | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
add log for kv gc and vlog gc
|
Rest LGTM |
only one new commit syndtr/goleveldb@02440ea Fix the stat about levels of the Stats API
|
LGTM |
IANTHEREAL
approved these changes
Jun 26, 2019
|
/run-all-tests |
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
Jul 1, 2019
…ap#648) 1, Add a API to trigger gc 2, Check L0 files by GetProperty instead of Stats Stats can't get the right L0 files num, see: https://github.com/syndtr/goleveldb/pull/283/files 3, call vlog.gcTS step by step, help free space quickly 4, update goleveldb dependency only one new commit syndtr/goleveldb@02440ea Fix the stat about levels of the Stats API
july2993
added a commit
that referenced
this pull request
Jul 2, 2019
…#658) 1, Add a API to trigger gc 2, Check L0 files by GetProperty instead of Stats Stats can't get the right L0 files num, see: https://github.com/syndtr/goleveldb/pull/283/files 3, call vlog.gcTS step by step, help free space quickly 4, update goleveldb dependency only one new commit syndtr/goleveldb@02440ea Fix the stat about levels of the Stats API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Refine gc of pump
What is changed and how it works?
1, Add a API to trigger gc
2, Check L0 files by GetProperty instead of Stats
Stats can't get the right L0 files num, see:
https://github.com/syndtr/goleveldb/pull/283/files
3, call vlog.gcTS step by step, help free space quickly
4, update goleveldb dependency
only one new commit
syndtr/goleveldb@02440ea
Fix the stat about levels of the Stats API
Check List
Tests
call
debug/gc/triggerCode changes
Side effects
Related changes