-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pump: Extract function and add unit tests #503
Conversation
/run-all-tests tidb=release-2.1 tikv=release-2.1 pd=release-2.1 |
/run-all-tests tidb=release-2.1 tikv=release-2.1 pd=release-2.1 |
@suzaku you can just push new commits to address comment, so reviewer will be easy seeing what is update, currently we always use |
@july2993 OK, so I don't have to rebase myself. But with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Refactor to make
NewAppendWithResolver
a little shorterWhat is changed and how it works?
Extract a new function
openMetadataDB
fromNewAppendWithResolver
Check List
Tests
Code changes
Side effects
Related changes