Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add auto sync configuration in creating etcd client (#1240) #1254

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1253

This is an automated cherry-pick of #1240

What problem does this PR solve?

Issue Number: close #1236

What is changed and how it works?

Add AutoSyncInterval configuration in creating etcd client.

Check List

Tests

  • None

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

fix the problem that drainer/pump can't work when pd's topology changes

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

@lichunzhu: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/M and removed size/XS labels Jun 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

@dsdashun: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/XS and removed size/M labels Jun 30, 2023
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsdashun, GMHDBJD, lichunzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [GMHDBJD,dsdashun,lichunzhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-30 09:57:19.345038472 +0000 UTC m=+79522.719616317: ☑️ agreed by lichunzhu.
  • 2023-06-30 10:17:44.273851085 +0000 UTC m=+80747.648428937: ☑️ agreed by GMHDBJD.

@ti-chi-bot ti-chi-bot bot merged commit 8668095 into pingcap:release-6.1 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants