Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drainer: skip alter attributes DDL #1083

Merged
merged 6 commits into from
Nov 1, 2021
Merged

drainer: skip alter attributes DDL #1083

merged 6 commits into from
Nov 1, 2021

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Oct 28, 2021

What problem does this PR solve?

This PR is going to solve the compatible issue of altering table/partition attributes DDL operation.

What is changed and how it works?

  • update parser
  • skip two kinds of DDLs

Check List

Tests

  • Unit test

Release note

  • No release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@rleungx
Copy link
Member Author

rleungx commented Oct 28, 2021

/run-all-tests

@rleungx
Copy link
Member Author

rleungx commented Oct 28, 2021

/run-all-tests

@rleungx
skip attributes ddl
ee36579 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Oct 29, 2021

/run-all-tests

@rleungx
skip attributes ddl
0b74557 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Oct 29, 2021

/run-all-tests

@rleungx
nolint for deprecated dependency
4d000e6 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Oct 29, 2021

/run-all-tests

1 similar comment
@rleungx
Copy link
Member Author

rleungx commented Oct 29, 2021

/run-all-tests

@rleungx
Copy link
Member Author

rleungx commented Oct 29, 2021

/run-all-tests

@rleungx
Copy link
Member Author

rleungx commented Oct 29, 2021

/run-all-tests

@rleungx rleungx force-pushed the skip-attributes branch 2 times, most recently from d42cbca to fd26dd8 Compare October 29, 2021 08:57
@rleungx
Copy link
Member Author

rleungx commented Oct 29, 2021

/run-all-tests

1 similar comment
@rleungx
Copy link
Member Author

rleungx commented Oct 29, 2021

/run-all-tests

@rleungx
Copy link
Member Author

rleungx commented Oct 29, 2021

/run-all-tests

@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fd26dd8

@rleungx
add ldflags
0e81e62 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0e81e62

@lichunzhu
Copy link
Contributor

/run-integration-tests

4 similar comments
@rleungx
Copy link
Member Author

rleungx commented Oct 29, 2021

/run-integration-tests

@rleungx
Copy link
Member Author

rleungx commented Oct 30, 2021

/run-integration-tests

@rleungx
Copy link
Member Author

rleungx commented Nov 1, 2021

/run-integration-tests

@rleungx
Copy link
Member Author

rleungx commented Nov 1, 2021

/run-integration-tests

@rleungx
address the comment
6dd0bbb 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Nov 1, 2021

/run-all-tests

@rleungx
update tidb-tools
27a0461 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Nov 1, 2021

/run-all-tests

@glorv
Copy link
Contributor

glorv commented Nov 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 27a0461

@ti-chi-bot ti-chi-bot merged commit 9f16f6e into pingcap:master Nov 1, 2021
@rleungx
Copy link
Member Author

rleungx commented Nov 1, 2021

/hold

@lichunzhu lichunzhu mentioned this pull request Nov 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
do-not-merge/hold size/XXL status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rleungx @ti-chi-bot @lichunzhu @glorv @3pointer