Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

reduce config items #978

Merged
merged 1 commit into from
Sep 29, 2019
Merged

reduce config items #978

merged 1 commit into from
Sep 29, 2019

Conversation

lucklove
Copy link
Member

Signed-off-by: lucklove gnu.crazier@gmail.com

Signed-off-by: lucklove <gnu.crazier@gmail.com>
Copy link
Contributor

@liubo0127 liubo0127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl
Copy link

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing these comments?


# Pseudo stats will be used if the ratio between the modify count and
# row count in statistics of a table is greater than it.
# pseudo-estimate-ratio: 0.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to keep them in the config files:

run-auto-analyze
feedback-probability
query-feedback-limit
pseudo-estimate-ratio

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucklove lucklove merged commit 761a2d6 into master Sep 29, 2019
# Queries with execution time greater than this value will be logged. (Milliseconds)
# slow-threshold: 300

# Queries with internal result greater than this value will be logged.
# expensive-threshold: 10000

# Maximum query length recorded in log.
Copy link
Contributor

@winkyao winkyao Sep 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we confirm that all the removed items is mentioned in documents?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll check it

lucklove added a commit that referenced this pull request Oct 14, 2019
Signed-off-by: lucklove <gnu.crazier@gmail.com>
@liubo0127 liubo0127 deleted the reduce-config-items branch November 5, 2019 11:09
liubo0127 added a commit to liubo0127/tidb-ansible that referenced this pull request Dec 6, 2019
liubo0127 added a commit that referenced this pull request Dec 6, 2019
* Revert "update release-3.0 config (#998)"

This reverts commit c156cb3.

* Revert "reduce config items (#978)"

This reverts commit 1043c3d.
liubo0127 added a commit to liubo0127/tidb-ansible that referenced this pull request Dec 6, 2019
liubo0127 added a commit that referenced this pull request Dec 6, 2019
* Revert "update release-3.0 config (#998)"

This reverts commit c156cb3.

* Revert "reduce config items (#978)"

This reverts commit 1043c3d.
# info-log-dir: ""

## Options for "Titan"
titan:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this? 🤣can you add it back?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All config items which been reduced have been added back.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which release version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master、3.1 and 3.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't see it in v3.0.7 and master

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update, added back in 3.0 and 3.1, master did not add. The released version can't be added back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also revert the change for titan in master?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants